KIP-890 (part 1) #600
Merged
KIP-890 (part 1) #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more of a forward looking commit, in that kadm will eventually introduce support for this. We now basically handle v4 properly, even though KIP-890 dictates that v4 isn't meant to be sent by clients, it is indeed still necessary and not sending it results in INVALID_TXN_STATE errors. Also properly adds the WriteTxnMarkers sharder to the switch, though nothing really should send that request so that doesn't really fix any bugs. Kafka 3.6 has an NPE handling produce requests frequently, see KAFKA-15653, so tests may fail against 3.6 occasionally.
This does not yet add V3_6_0 since that will require a minor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handles sharding AddPartitionsToTxn v4+, and we now detect Kafka 3.6 properly (although do not introduce a constant for it yet which would require a minor).